Convert Factur-X user messages to English#531
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d95d88312e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| showMessage(t('gestion', 'Factur-X XML file generated and saved.')); | ||
| }) | ||
| .catch(error => { | ||
| showMessage(t('gestion', 'Erreur lors de la génération du XML : ') + error.message); | ||
| showMessage(t('gestion', 'Error generating the XML: ') + error.message); |
There was a problem hiding this comment.
Keep Factur-X XML translations wired up
For locales that already translate the old Factur-X XML messages, the new t() source strings here are absent from l10n/ while the catalogs still contain the previous French keys such as Fichier XML Factur-X généré et sauvegardé. and Erreur lors de la génération du XML : (verified with rg). Since Nextcloud translation lookup uses the source string as the key, XML generation success/failure messages now fall back to English for those users instead of their existing translations; please update the localization catalogs alongside the key change or otherwise preserve the old keys.
Useful? React with 👍 / 👎.
Motivation
Description
src/js/pdf.jsandsrc/js/modules/ajaxRequest.js, committed on branchcodex/issue-529, and opened this draft PR targetingmaster.Testing
node --check src/js/pdf.jsandnode --check src/js/modules/ajaxRequest.js, which passed, andgit diff --check, which passed;npm run buildfailed due to an external network fetch of Google Fonts returning HTTP 403;npx eslint src/js/pdf.js src/js/modules/ajaxRequest.jscould not run because the repository does not include an ESLint flat config file.Codex Task