Skip to content

Convert Factur-X user messages to English#531

Merged
baimard merged 1 commit into
masterfrom
codex/corrige-l-issue-de-messages-utilisateur-factur-x
Jun 30, 2026
Merged

Convert Factur-X user messages to English#531
baimard merged 1 commit into
masterfrom
codex/corrige-l-issue-de-messages-utilisateur-factur-x

Conversation

@baimard

@baimard baimard commented Jun 30, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Convert remaining Factur‑X user-facing messages and PDF/XML fallback server error texts from French to English so the UI messaging is consistent.

Description

  • Replaced French strings with English equivalents in src/js/pdf.js and src/js/modules/ajaxRequest.js, committed on branch codex/issue-529, and opened this draft PR targeting master.

Testing

  • Ran node --check src/js/pdf.js and node --check src/js/modules/ajaxRequest.js, which passed, and git diff --check, which passed; npm run build failed due to an external network fetch of Google Fonts returning HTTP 403; npx eslint src/js/pdf.js src/js/modules/ajaxRequest.js could not run because the repository does not include an ESLint flat config file.

Codex Task

@baimard baimard marked this pull request as ready for review June 30, 2026 14:18
@baimard baimard merged commit c010f53 into master Jun 30, 2026
2 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d95d88312e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +647 to +650
showMessage(t('gestion', 'Factur-X XML file generated and saved.'));
})
.catch(error => {
showMessage(t('gestion', 'Erreur lors de la génération du XML : ') + error.message);
showMessage(t('gestion', 'Error generating the XML: ') + error.message);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep Factur-X XML translations wired up

For locales that already translate the old Factur-X XML messages, the new t() source strings here are absent from l10n/ while the catalogs still contain the previous French keys such as Fichier XML Factur-X généré et sauvegardé. and Erreur lors de la génération du XML : (verified with rg). Since Nextcloud translation lookup uses the source string as the key, XML generation success/failure messages now fall back to English for those users instead of their existing translations; please update the localization catalogs alongside the key change or otherwise preserve the old keys.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant