You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@fabitom Thank you for the PR.
Is your feature branch merged with the latest master?
I see file changes from the other PR which is already merged to master. So it's some extra noise in this PR. I know it will be theoretically ignored while merging.
right, I just made ring-buffer-demo branch based on previous. But there was no changes. Should I fork again ? what is right way ? I'm not an expert git ;(
Definitely not. Just merge the stuff from master to your feature branch.
It would be something like described here.
So the point 1 of this answer. The "feature" is your branch "ring-buffer-demo". Please do a local backup of the folder ;-) Nothing wrong should happen, just in case.
Github describes it also here, but I guess you don't use this GithubDesktop whatever it is.
PS: After all, the PR should be updated, of course.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is simple ring buffer demo based on Edzelf/ESP32-Radio