Fix DownloadImageModal submit button being disabled when switching from a device type that has wifi network capability to one that does not

[myarmolinsky]

Fix DownloadImageModal submit button being disabled when switching from a device type that has wifi network capability to one that does not

Change-type: patch
Signed-off-by: Matthew Yarmolinsky matthew-timothy@balena.io

---

Contributor checklist

• I have regenerated jest snapshots for any affected components with npm run generate-snapshots

Reviewer Guidelines

• When submitting a review, please pick:
  • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
  • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
  • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

---

[thgreasi]

Could we instead try to clear the state properties that are not in the options any more?
Then the title would become:

DownloadImageModal: Fix disabling submit when switching between DTs that have different options

[myarmolinsky]

If we clear the state properties of options that are not there anymore, that means we will also lose the input the user stored for wifi credentials when they go from wifi -> no wifi -> wifi (currently if I enter a network and password, then switch to a DT with no wifi, then switch back to a DT with wifi, the network and password I entered remain). All of this data on the model state. So we cannot just clear all state that is not relevant to the current DT because then if the user switches back and forth between DTs, we would be inconveniencing them by making them re-enter all the data they entered priorly. Perhaps we don't want the data persisting anyway though, what do you think about it all? @thgreasi