fix: validate skill and source names against path traversal#5
Open
Vishwaspatel2401 wants to merge 1 commit intobalgaly:masterfrom
Open
fix: validate skill and source names against path traversal#5Vishwaspatel2401 wants to merge 1 commit intobalgaly:masterfrom
Vishwaspatel2401 wants to merge 1 commit intobalgaly:masterfrom
Conversation
Extend the existing DANGEROUS_KEYS protection in addSkill() and addSource() to also reject names containing path traversal sequences (.. / \ and URL-encoded equivalents %2F %5C). Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the existing prototype pollution protection in
src/core/manifest.jsto also block path traversal attacks in skill and source names.Before: Only
__proto__,constructor, andprototypewere rejected.After: Names containing
..,/,\,%2F, or%5Care also rejected in bothaddSkill()andaddSource().Changes
INVALID_NAME_PATTERNconstant tosrc/core/manifest.jsaddSource()andaddSkill()before writing to manifestTesting
All 375 previously passing tests continue to pass. The 6 failing tests are pre-existing failures unrelated to this change.