fix: prune old manifest backups after discover runs#6
Open
Vishwaspatel2401 wants to merge 1 commit intobalgaly:masterfrom
Open
fix: prune old manifest backups after discover runs#6Vishwaspatel2401 wants to merge 1 commit intobalgaly:masterfrom
Vishwaspatel2401 wants to merge 1 commit intobalgaly:masterfrom
Conversation
Keep only the 5 most recent manifest.backup-*.json files after each discover run to prevent unbounded disk growth on long-running systems. Closes balgaly#4 Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4 — manifest backup files were created on every
skit discoverrun but never cleaned up, causing unbounded disk growth.After writing a new backup, the fix scans for all
manifest.backup-*.jsonfiles inskitHome, sorts them by name (timestamps sort lexicographically), and deletes all but the 5 most recent.Changes
src/commands/discover.js— added backup pruning block immediately after the backup is writtenBehaviour
discoverruns: all backups kept as beforeTesting
All 375 previously passing tests continue to pass. The 6 failing tests are pre-existing failures unrelated to this change.