This repository was archived by the owner on Jun 3, 2020. It is now read-only.
Sidebar Element as Semantic HTML (Nav)#139
Open
joeflack4 wants to merge 1 commit intoballoob:masterfrom
Open
Conversation
joeflack4
force-pushed
the
pr_allow-nav
branch
from
faafe63 to
f6f3e9e
Compare
…r semantic html (nav).
joeflack4
force-pushed
the
pr_allow-nav
branch
from
f6f3e9e to
414ba87
Compare
Collaborator
|
Is there a way to let the user set the sidebar to any tag they want instead? It seems to me like the |
Collaborator
|
You know, as I think more about this it seems kind of unnecessary to let users of the library decide what the root sidebar tag should be. They can just as well create a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ability for root element to be either non-semantic html (div) or semantic html (nav).