Skip to content

fix(report): type matplotlib handles#6

Merged
bamdadd merged 1 commit into
bamdadd:mainfrom
Minghan2005:agent/fix-matplotlib-typing
Jul 14, 2026
Merged

fix(report): type matplotlib handles#6
bamdadd merged 1 commit into
bamdadd:mainfrom
Minghan2005:agent/fix-matplotlib-typing

Conversation

@Minghan2005

Copy link
Copy Markdown
Contributor

Summary

  • add type-only matplotlib Artist and Figure imports
  • type the layer-chart legend handles and PNG serializer precisely
  • retain lazy runtime matplotlib imports so the core package remains dependency-free

Validation

  • core environment: mypy src
  • matplotlib environment: mypy src, ruff check ., ruff format --check ., pytest -q (51 passed)

Closes #2

@Minghan2005
Minghan2005 force-pushed the agent/fix-matplotlib-typing branch from 54ab04f to 1c49f95 Compare July 14, 2026 17:32
@Minghan2005
Minghan2005 marked this pull request as ready for review July 14, 2026 17:36
@Minghan2005

Copy link
Copy Markdown
Contributor Author

I’ve rebased this branch onto the latest main and marked the PR ready for review. Local validation passes (ruff, mypy, and 51 tests). The new Actions run is waiting for maintainer approval; could you please approve it when convenient?

@bamdadd
bamdadd merged commit ec700e4 into bamdadd:main Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix matplotlib typing in report.py so mypy is clean under the report extra

2 participants