Conversation
|
Hey @NicoHood , thanks for being a contributor. Feel free to help as little or as much as you are able. No obligation or expectations. I did assign you as a reviewer on this PR. I may ask you to review some other PR's upcoming if you have the time. It would be good to have someone else reviewing the changes other than myself. Again, no expectations here, and if you feel like you want to help review PR's and it becomes more than you are interested in doing, also let me know. |
NicoHood
left a comment
NicoHood
left a comment
There was a problem hiding this comment.
I currently aint got time to test everything (yeah, it would be much better), but I gave it a visual review. thanks for your trust :-)
| else | ||
| for x in $UUIDS; do | ||
| UUIDS_ARRAY[$i]=$x | ||
| if [[ "$x" == "$uuid_cmdline" && ${SUBVOLIDS_ARRAY[$((i))]} == "$subvolid_cmdline" && ${TARGETS_ARRAY[$((i))]} == "$mount_cmdline" ]]; then |
There was a problem hiding this comment.
I would do something like:
if [[ -n "$mount_cmdline" && ${TARGETS_ARRAY[$((i))]} != "$mount_cmdline" ]]; then
continue
fi
This should make the code smaller, but I did not test it.
2 participants
Add option to specify mount point. Fixes #71