Draft
Conversation
Author
|
I also am not sure if |
Author
|
PR will need a rework for the new modal changes (https://discord.com/developers/docs/change-log#introducing-new-modal-components) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two derive macros
ModalModelandCreateModalas analogues toCommandModelandCreateCommand.Short example:
Draft pending
custom_idhandling to allow generating it at runtimeRegarding the
custom_idhandling:A
custom_idneeds to be able to be set at runtime, otherwise it is impossible to distinguish replies for different instances of the same modal from each other.To solve this, I plan to remove thecustom_idattribute and instead give thecreate_modalfunction acustom_idparameter.This has been solved by removing the
custom_idattribute and instead giving thecreate_modalfunction acustom_idparameter.Closes #15