Fix Pydantic error in API #188
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorentPoinsaut
suggested changes
Jul 2, 2025
Contributor
FlorentPoinsaut
left a comment
FlorentPoinsaut
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
It works well for me!
I suggest some optimization.
Regards,
| RUN pip install --no-cache-dir --upgrade pip==22.0.4 | ||
|
|
||
| # Required for installation of Python sslpsk package | ||
| RUN apk add build-base openssl-dev |
Contributor
There was a problem hiding this comment.
Suggested change
| RUN apk add build-base openssl-dev | |
| RUN apk add --no-cache build-base openssl-dev |
| RUN pip install --no-cache-dir --upgrade pip==22.0.4 | ||
|
|
||
| # Required for installation of Python sslpsk package | ||
| RUN apk add build-base openssl-dev |
Contributor
There was a problem hiding this comment.
Suggested change
| RUN apk add build-base openssl-dev | |
| RUN apk add --no-cache build-base openssl-dev |
|
|
||
| # Support connection encryption via TLS-PSK | ||
| RUN pip install --no-cache-dir "sslpsk" | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| USER root | |
| RUN apk del build-base openssl-dev | |
| USER bareos |
|
|
||
| # Support connection encryption via TLS-PSK | ||
| RUN pip install --no-cache-dir "sslpsk" | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| USER root | |
| RUN apk del build-base openssl-dev | |
| USER bareos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @barcus! Thank you for your work on this repository: it helped me a lot exploring the functionality bareos offers :)
Before I got things up and running though, like @k3nd0x I ran into #187. I included a workaround for this problem in this PR, which pins Pydantic to the newest 1.x version.
So not really a proper fix, but it might come in handy for the time being.