Tkt 1610 change logo without restart#1723
Open
upuente001 wants to merge 2 commits intobardsoftware:masterfrom
Open
Tkt 1610 change logo without restart#1723upuente001 wants to merge 2 commits intobardsoftware:masterfrom
upuente001 wants to merge 2 commits intobardsoftware:masterfrom
Conversation
dbarashev
reviewed
Mar 23, 2020
| }); | ||
| } | ||
| void replaceImagePanel(Image image){ | ||
| myImagePanel.setIcon(new ImageIcon(image.getScaledInstance(-1, 50, Image.SCALE_DEFAULT))); |
Contributor
There was a problem hiding this comment.
any reason why the height must be 50px? There are calculations in the code below which take into account DPI setting. They probably shall not be ignored?
| Image newLogo =getLogo(); | ||
|
|
||
|
|
||
| ((GanttTree2)myFallbackDelegate.getTaskTree()). |
Contributor
There was a problem hiding this comment.
I don't think that we want to expose that many internal fields and do all these casts to concrete classes and call chains.
What about exposing LogoOption from UIFacade instead? Class ChartTabContentPanel has access to UIFacade instance, it will be able to get the logo option and add a listener.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the logo without restart