Add a way to provide a composite context with <% include %>#88
Open
tifosiblack wants to merge 1 commit intobaryshev:masterfrom
tifosiblack:master
Open
Add a way to provide a composite context with <% include %>#88tifosiblack wants to merge 1 commit intobaryshev:masterfrom tifosiblack:master
tifosiblack wants to merge 1 commit intobaryshev:masterfrom
tifosiblack:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Vadim,
I propose this pull request, in order to be able to pass a 'this' extended context through an include.
This way I'm able to include reusable component like that and still be able to use global headers, like translation, defined into 'this' :
Context is merge into a new object in this case. The behaviour is unchanged in other cases.