Audit findings batch 1 (Chris): info/gas/low fixes#23
Merged
Conversation
… _installForReplace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses audit findings 2–7 (informational, gas optimization, and low severity).
Findings
PublicERC6492ValidatorNatSpec — pointed tospend-permissionsinstead ofaccount-policiesreplaceWithSignature— the same check already exists in_replace, so the storage reads and conditional in the caller were wasted_uninstallForReplaceand_installForReplace— avoids redundantkeccak256slot computations,SLOADs, and agetPolicyIdrecomputationpolicyRecordByBinding.uninstalled = trueabove theinstalledbranch in binding-mode_uninstall— set unconditionally since both branches wrote itwhenNotPausedfrom_onExecutemodifier to function body, after the empty-executionDataearly return — alignsinstallWithSignaturebehavior withinstall(both now succeed while paused)setPolicyManager— preserves the migration use case but warns admins about install-state assumptions a new manager must upholdTesting
All 288 tests pass. No new test files; one existing test updated to reflect finding #6 behavior change.