Fix IsProofFinalized to use withdrawal hash instead of L2 tx hash #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
🟡 Heimdall Review Status
|
The IsProofFinalized() functions in both Withdrawer and FPWithdrawer were incorrectly passing the L2 transaction hash to FinalizedWithdrawals instead of the withdrawal hash. This bug would cause the function to always return false since the wrong hash was being checked. The fix calculates the proper withdrawal hash from the transaction receipt (using ParseMessagePassed and WithdrawalHash) before checking if the withdrawal is finalized, consistent with how other functions like GetProvenWithdrawalTime() and FinalizeWithdrawal() work. Co-authored-by: openhands <openhands@all-hands.dev>
saddam92
force-pushed
the
fix/is-proof-finalized-withdrawal-hash
branch
from
5cac65a to
5532036
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IsProofFinalized() functions in both Withdrawer and FPWithdrawer were incorrectly passing the L2 transaction hash to FinalizedWithdrawals instead of the withdrawal hash. This bug would cause the function to always return false since the wrong hash was being checked.
The fix calculates the proper withdrawal hash from the transaction receipt (using ParseMessagePassed and WithdrawalHash) before checking if the withdrawal is finalized, consistent with how other functions like GetProvenWithdrawalTime() and FinalizeWithdrawal() work.