Retry the repair-PR re-verification while the API catches up - #13
Merged
Conversation
Second exercise run: the lease push succeeded but the immediate gh pr list read returned the pre-push head, so the fail-closed re-verification refused to arm auto-merge (run 30308977272). Poll up to 30s for the reported head to reach the pushed commit; a mismatch after the window still refuses.
There was a problem hiding this comment.
Pull request overview
This PR reduces false-negative “re-verification” failures when immediately querying the PR API after force-pushing the repair branch, by polling briefly until the PR’s reported head SHA matches the newly pushed commit before proceeding with auto-merge arming.
Changes:
- Add a bounded retry/poll loop around
gh pr listto wait for the PR API’sheadRefOidto reflect the just-pushedNEW_HEAD. - Keep the existing fail-closed verification (exact head SHA, base branch, author) before enabling auto-merge.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jeremy
added a commit
to basecamp/basecamp-sdk
that referenced
this pull request
Jul 27, 2026
basecamp/.github#13: bounded poll for the PR API to catch up with the lease push before the fail-closed head check judges. This merge's push is exercise round 3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exercise iteration 2 (run 30308977272): the lease push landed — PR head reads 37d6c2f6 now — but the immediate
gh pr listre-verification saw the pre-push head and refused to arm auto-merge (fail-closed, as designed). Bounded 30s poll for the reported head to equal the pushed commit; mismatch after the window still refuses.