Skip to content

Drop dead .claude-plugin component payload#548

Open
jeremy wants to merge 1 commit into
mainfrom
jeremy/chore-claude-plugin-dead-payload
Open

Drop dead .claude-plugin component payload#548
jeremy wants to merge 1 commit into
mainfrom
jeremy/chore-claude-plugin-dead-payload

Conversation

@jeremy

@jeremy jeremy commented Jul 21, 2026

Copy link
Copy Markdown
Member

chore: drop dead .claude-plugin/ component payload

What

Deletes .claude-plugin/{hooks,commands,skills} — five files nothing loads:

  • .claude-plugin/hooks/{hooks.json,session-start.sh,post-commit-check.sh}
  • .claude-plugin/commands/doctor.md
  • .claude-plugin/skills/basecamp (symlink; the real skills/ directory stays)

.claude-plugin/plugin.json stays — it is the manifest Claude Code actually reads, and the release stamping (release.sh, stamp-plugin-version.sh) and internal/release/manifests_test.go fixtures all point at it.

Why this is safe

Claude Code has never loaded components from inside .claude-plugin/. The current plugins reference requires commands/, skills/, hooks/, etc. at the plugin root, and the launch-era docs (v2.0.12, archived 2025-10-15, contemporaneous with the plugin launch) said the same — they list the .claude-plugin/ placement as a troubleshooting failure cause. Codex likewise reads only .codex-plugin/plugin.json plus root locations. So no supported version of either agent ever saw these files: they are dead payload shipped inside the installed plugin.

Credit where due: #534's review surfaced this latent dead payload.

Zero functional references to the deleted paths remain (the only matches were self-references inside the deleted tree). .github/labeler.yml's .claude-plugin/** glob still matches plugin.json, so it stays as is.

doctor.md is deliberately not resurrected at root commands/ — that would create a new /basecamp:doctor Claude surface; the agent-neutral basecamp-doctor skill already covers both agents.

The behavior the old .claude-plugin/hooks/session-start.sh intended returns for real in Phase 2's first-party hooks (hooks/hooks.json + basecamp agent-hook), landing separately.

Verification

  • bin/ci green.
  • Staging-plugin check on both agents (candidate worktree loaded directly, production plugin isolated first): fresh threads still load both skills.

Summary by cubic

Drop unused component files inside .claude-plugin that are never loaded by the plugin. Keeps the manifest; reduces plugin size with no behavior change.

  • Refactors
    • Deleted hooks/*, commands/doctor.md, and skills/basecamp symlink under .claude-plugin/.
    • Kept .claude-plugin/plugin.json for release stamping and tests.
    • Did not move doctor.md to root commands/ to avoid a new /basecamp:doctor; the basecamp-doctor skill already covers this.

Written for commit f76e3ba. Summary will update on new commits.

Review in cubic

.claude-plugin/{hooks,commands,skills} were never component locations:
Claude Code has always required commands/, skills/, and hooks/ at the
plugin root, and the launch-era plugins reference (v2.0.12, archived
2025-10-15) lists the .claude-plugin/ placement as a troubleshooting
failure cause. Codex reads only .codex-plugin/plugin.json plus root
locations. No supported version of either agent ever loaded these
files, so they ship as dead payload inside the installed plugin.

Delete the unloaded hooks, the doctor command, and the skills symlink.
Keep .claude-plugin/plugin.json — the manifest both release stamping
and manifests_test.go point at. The real skills/ directory stays. The
behavior session-start.sh intended returns for real with the shared
first-party hooks in Phase 2.
Copilot AI review requested due to automatic review settings July 21, 2026 04:36
@github-actions github-actions Bot added the plugin Claude Code plugin label Jul 21, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Re-trigger cubic

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes unused component payload files under .claude-plugin/ (hooks, commands, and a skills symlink) while keeping .claude-plugin/plugin.json intact for release stamping and manifest checks, reducing dead shipped content without changing runtime behavior.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

Changes:

  • Delete dead Claude plugin component files under .claude-plugin/hooks/ (hook scripts + hooks.json).
  • Delete .claude-plugin/commands/doctor.md to avoid introducing a new Claude surface command.
  • Remove .claude-plugin/skills/basecamp symlink (the real skills/ directory remains).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.claude-plugin/hooks/session-start.sh Deleted unused Claude hook script payload under .claude-plugin/.
.claude-plugin/hooks/post-commit-check.sh Deleted unused Claude hook script payload under .claude-plugin/.
.claude-plugin/hooks/hooks.json Deleted unused Claude hook config payload under .claude-plugin/.
.claude-plugin/commands/doctor.md Deleted unused Claude command payload under .claude-plugin/.
.claude-plugin/skills/basecamp Deleted unused symlinked skill payload under .claude-plugin/.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin Claude Code plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants