Drop dead .claude-plugin component payload#548
Open
jeremy wants to merge 1 commit into
Open
Conversation
.claude-plugin/{hooks,commands,skills} were never component locations:
Claude Code has always required commands/, skills/, and hooks/ at the
plugin root, and the launch-era plugins reference (v2.0.12, archived
2025-10-15) lists the .claude-plugin/ placement as a troubleshooting
failure cause. Codex reads only .codex-plugin/plugin.json plus root
locations. No supported version of either agent ever loaded these
files, so they ship as dead payload inside the installed plugin.
Delete the unloaded hooks, the doctor command, and the skills symlink.
Keep .claude-plugin/plugin.json — the manifest both release stamping
and manifests_test.go point at. The real skills/ directory stays. The
behavior session-start.sh intended returns for real with the shared
first-party hooks in Phase 2.
There was a problem hiding this comment.
Pull request overview
This PR removes unused component payload files under .claude-plugin/ (hooks, commands, and a skills symlink) while keeping .claude-plugin/plugin.json intact for release stamping and manifest checks, reducing dead shipped content without changing runtime behavior.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Changes:
- Delete dead Claude plugin component files under
.claude-plugin/hooks/(hook scripts +hooks.json). - Delete
.claude-plugin/commands/doctor.mdto avoid introducing a new Claude surface command. - Remove
.claude-plugin/skills/basecampsymlink (the realskills/directory remains).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .claude-plugin/hooks/session-start.sh | Deleted unused Claude hook script payload under .claude-plugin/. |
| .claude-plugin/hooks/post-commit-check.sh | Deleted unused Claude hook script payload under .claude-plugin/. |
| .claude-plugin/hooks/hooks.json | Deleted unused Claude hook config payload under .claude-plugin/. |
| .claude-plugin/commands/doctor.md | Deleted unused Claude command payload under .claude-plugin/. |
| .claude-plugin/skills/basecamp | Deleted unused symlinked skill payload under .claude-plugin/. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: drop dead
.claude-plugin/component payloadWhat
Deletes
.claude-plugin/{hooks,commands,skills}— five files nothing loads:.claude-plugin/hooks/{hooks.json,session-start.sh,post-commit-check.sh}.claude-plugin/commands/doctor.md.claude-plugin/skills/basecamp(symlink; the realskills/directory stays).claude-plugin/plugin.jsonstays — it is the manifest Claude Code actually reads, and the release stamping (release.sh,stamp-plugin-version.sh) andinternal/release/manifests_test.gofixtures all point at it.Why this is safe
Claude Code has never loaded components from inside
.claude-plugin/. The current plugins reference requirescommands/,skills/,hooks/, etc. at the plugin root, and the launch-era docs (v2.0.12, archived 2025-10-15, contemporaneous with the plugin launch) said the same — they list the.claude-plugin/placement as a troubleshooting failure cause. Codex likewise reads only.codex-plugin/plugin.jsonplus root locations. So no supported version of either agent ever saw these files: they are dead payload shipped inside the installed plugin.Credit where due: #534's review surfaced this latent dead payload.
Zero functional references to the deleted paths remain (the only matches were self-references inside the deleted tree).
.github/labeler.yml's.claude-plugin/**glob still matchesplugin.json, so it stays as is.doctor.mdis deliberately not resurrected at rootcommands/— that would create a new/basecamp:doctorClaude surface; the agent-neutralbasecamp-doctorskill already covers both agents.The behavior the old
.claude-plugin/hooks/session-start.shintended returns for real in Phase 2's first-party hooks (hooks/hooks.json+basecamp agent-hook), landing separately.Verification
bin/cigreen.Summary by cubic
Drop unused component files inside
.claude-pluginthat are never loaded by the plugin. Keeps the manifest; reduces plugin size with no behavior change.hooks/*,commands/doctor.md, andskills/basecampsymlink under.claude-plugin/..claude-plugin/plugin.jsonfor release stamping and tests.doctor.mdto rootcommands/to avoid a new/basecamp:doctor; thebasecamp-doctorskill already covers this.Written for commit f76e3ba. Summary will update on new commits.