Skip to content

Bare pin comments: let Dependabot maintain action version comments - #576

Merged
jeremy merged 1 commit into
mainfrom
ci/bare-pin-comments
Jul 27, 2026
Merged

Bare pin comments: let Dependabot maintain action version comments#576
jeremy merged 1 commit into
mainfrom
ci/bare-pin-comments

Conversation

@jeremy

@jeremy jeremy commented Jul 27, 2026

Copy link
Copy Markdown
Member

Dependabot rewrites bare # vX.Y.Z comments on pinned uses: lines natively but cannot touch compound ones carrying a trailing # zizmor: ignore[...]. Moving each ignore to its own line directly below the pin (reason text kept, association verified under zizmor 1.28) makes Dependabot itself the comment maintainer — no push automation required on its PRs. Same restructure basecamp-sdk shipped in basecamp-sdk#458. Part of the post-merge redesign of the comment-sync program (see basecamp/.github#10 for why in-PR pushing is unsafe: a deploy-key push flips the run actor off dependabot[bot] and lifts the Dependabot sandbox for the unreviewed bumped actions).


Summary by cubic

Move zizmor ignores to their own line under each pinned uses: so Dependabot can update bare # vX.Y.Z comments automatically. Upgrade zizmorcore/zizmor-action to v0.6.0 to ensure standalone ignore comments are recognized.

  • Refactors

    • Split trailing # zizmor: ignore[...] off uses: pins in release.yml; reasons preserved.
    • No workflow behavior changes.
  • Dependencies

    • Bumped zizmorcore/zizmor-action from v0.5.7 to v0.6.0 in test.yml to support standalone ignore association.

Written for commit eda3bc4. Summary will update on new commits.

Review in cubic

…n comments

Dependabot rewrites bare version comments natively but cannot touch
compound ones carrying a trailing zizmor ignore. One line per pin plus a
standalone ignore below it (same restructure as basecamp-sdk#458) makes
Dependabot the first line of defense with no push automation needed on
its PRs.

Also normalizes zizmor-action to v0.6.0 so the audit runs a zizmor that
associates standalone ignore comments (the 1.23-era resolution of older
action versions does not).
Copilot AI review requested due to automatic review settings July 27, 2026 21:21
@github-actions github-actions Bot added the ci CI/CD workflows label Jul 27, 2026
@github-actions

Copy link
Copy Markdown

Sensitive Change Detection (shadow mode)

This PR modifies control-plane files:

  • .github/workflows/release.yml
  • .github/workflows/test.yml

Shadow mode — this check is informational only. When activated, changes to these paths will require approval from a maintainer.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts GitHub Actions workflow annotations so Dependabot can maintain the bare pinned-action version comments automatically, while keeping zizmor ignores effective (by moving them onto their own adjacent comment line). It also bumps the zizmorcore/zizmor-action version to ensure standalone ignore comments are recognized.

Changes:

  • Bump zizmorcore/zizmor-action pin from v0.5.7 to v0.6.0 in the CI workflow.
  • Refactor release.yml to move trailing # zizmor: ignore[...] from inline uses: comments onto their own line directly below the pin (reasons preserved).

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/test.yml Updates the pinned zizmorcore/zizmor-action SHA/comment to v0.6.0.
.github/workflows/release.yml Splits inline zizmor ignore annotations onto their own adjacent line so Dependabot can manage bare # vX.Y.Z comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@jeremy
jeremy merged commit 08ce8ad into main Jul 27, 2026
27 checks passed
@jeremy
jeremy deleted the ci/bare-pin-comments branch July 27, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI/CD workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants