Skip to content

BC5 OAuth: resource-first discovery, device-flow login, RFC 8707 resource echo #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jeremy wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

BC5 OAuth: resource-first discovery, device-flow login, RFC 8707 resource echo #582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
161840e
auth: adopt resource-first OAuth discovery and RFC 8628 device flow
jeremy Jul 16, 2026
82bb490
auth: cover device flow, discovery fallbacks, and refresh behavior
jeremy Jul 16, 2026
29f7b6c
docs: describe device-flow login and retire client.json references
jeremy Jul 16, 2026
dab110c
auth: harden device display boundary; cover profile --device-code map…
jeremy Jul 16, 2026
7ef25c5
go: drop stale SDK pseudo-version go.sum entries left by restack
jeremy Jul 28, 2026
b088655
auth: persist and echo the RFC 8707 resource indicator across refreshes
jeremy Jul 28, 2026
bf5df0b
auth: canonicalize the resource origin; restack onto keyring-probe main
jeremy Jul 28, 2026
6656378
go: pin the SDK at oauth-resource-indicator 819c0b86
jeremy Jul 28, 2026
2414bc6
go: pin the SDK at oauth-resource-indicator e9469832
jeremy Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,15 @@ Breadcrumbs suggest next commands, making it easy for humans and agents to navig

## Authentication

OAuth 2.1 with automatic token refresh. First login opens your browser:
OAuth 2.1 with automatic token refresh. First login opens your browser.
When the server supports it, login uses the OAuth device flow automatically:
you approve a short code in the browser instead of a redirect. Otherwise
login falls back to Launchpad's authorization-code flow.

```bash
basecamp auth login # Authenticate with Basecamp
basecamp auth login --scope read # Read-only access (BC3 OAuth only, default)
basecamp auth login --scope full # Full read+write access (BC3 OAuth only)
basecamp auth login --scope read # Read-only access (default; ignored by Launchpad)
basecamp auth login --scope full # Full read+write access (ignored by Launchpad)
basecamp auth token # Print token for scripts
```

Expand Down Expand Up @@ -175,7 +178,6 @@ See [install.md](install.md) for step-by-step setup instructions.
```
~/.config/basecamp/ # Your Basecamp identity
├── credentials.json # OAuth tokens (fallback when keyring unavailable)
├── client.json # DCR client registration
└── config.json # Global preferences

~/.config/basecamp/theme/ # Tool display (optional)
Expand All @@ -189,6 +191,9 @@ See [install.md](install.md) for step-by-step setup instructions.
└── config.json # Project, account defaults
```

A leftover `~/.config/basecamp/client.json` (from the removed development
client-registration flow) is obsolete and safe to delete.

## Troubleshooting

```bash
Expand Down
14 changes: 14 additions & 0 deletions e2e/auth.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,20 @@ load test_helper
assert_output_contains "--device-code"
}

@test "basecamp auth login --help describes flags provider-neutrally" {
run basecamp auth login --help
assert_success
assert_output_contains "Headless authentication with manual browser instructions"
assert_output_contains "ignored by Launchpad"
}

@test "basecamp profile create --help describes flags provider-neutrally" {
run basecamp profile create --help
assert_success
assert_output_contains "Headless authentication with manual browser instructions"
assert_output_contains "ignored by Launchpad"
}

@test "basecamp auth login rejects --device-code --local" {
run basecamp auth login --device-code --local
assert_failure
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ require (
charm.land/bubbles/v2 v2.1.1
charm.land/bubbletea/v2 v2.0.8
charm.land/lipgloss/v2 v2.0.5
github.com/basecamp/basecamp-sdk/go v0.9.1-0.20260727173625-bb363c847b92
github.com/basecamp/basecamp-sdk/go v0.9.1-0.20260728112802-e9469832f102
github.com/basecamp/cli v0.2.2-0.20260728023309-04e401b12c6c
github.com/charmbracelet/bubbles v1.0.0
github.com/charmbracelet/glamour v1.0.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ github.com/aymanbagabas/go-udiff v0.4.1 h1:OEIrQ8maEeDBXQDoGCbbTTXYJMYRCRO1fnodZ
github.com/aymanbagabas/go-udiff v0.4.1/go.mod h1:0L9PGwj20lrtmEMeyw4WKJ/TMyDtvAoK9bf2u/mNo3w=
github.com/aymerick/douceur v0.2.0 h1:Mv+mAeH1Q+n9Fr+oyamOlAkUNPWPlA8PPGR0QAaYuPk=
github.com/aymerick/douceur v0.2.0/go.mod h1:wlT5vV2O3h55X9m7iVYN0TBM0NH/MmbLnd30/FjWUq4=
github.com/basecamp/basecamp-sdk/go v0.9.1-0.20260727173625-bb363c847b92 h1:4gQJTR8e5kBvXHDHLvef+Q00XY7KzWTxnQSLWMSPcyA=
github.com/basecamp/basecamp-sdk/go v0.9.1-0.20260727173625-bb363c847b92/go.mod h1:r83ralDQ0q9vbAby5qQ5x9hgCgUdJLDLHYpiU6jaFjE=
github.com/basecamp/basecamp-sdk/go v0.9.1-0.20260728112802-e9469832f102 h1:s/pAB1d7CAh0aNG6oeu2EwWCRrVTw11pWLWb6fzZIIw=
github.com/basecamp/basecamp-sdk/go v0.9.1-0.20260728112802-e9469832f102/go.mod h1:r83ralDQ0q9vbAby5qQ5x9hgCgUdJLDLHYpiU6jaFjE=
github.com/basecamp/cli v0.2.2-0.20260728023309-04e401b12c6c h1:+5sQBl8sqYoD1Qhwsibn8sBCKWPyZ9NDez6mnuo9Afo=
github.com/basecamp/cli v0.2.2-0.20260728023309-04e401b12c6c/go.mod h1:EK1Dba6DEw8ZAilVBpf/jri3ONDV7LQkLACSDe73f/c=
github.com/bmatcuk/doublestar v1.1.1/go.mod h1:UD6OnuiIn0yFxxA2le/rnRU1G4RaI4UvFv1sNto9p6w=
Expand Down
Loading
Loading