Fix npm Audit: bump fast-uri, brace-expansion, js-yaml overrides#385
Merged
Conversation
…sh advisories Three high-severity advisories published since the last green security run (2026-07-20) trip npm Audit on the TypeScript SDK for every PR: - fast-uri GHSA-4c8g-83qw-93j6 (host confusion via failed IDN canonicalization): new override >=3.1.3, resolves 4.1.1 - brace-expansion GHSA-3jxr-9vmj-r5cp (DoS via exponential expansion): new override >=5.0.7 - js-yaml GHSA-52cp-r559-cp3m (quadratic CPU via merge-key chains): new override ^4.3.0, pinned to the 4.x patched line since js-yaml 5 is a major bump for openapi-typescript's transitive use npm audit clean; ts build + tests green under the new resolutions.
There was a problem hiding this comment.
Pull request overview
This PR addresses newly published high-severity npm advisories affecting the TypeScript SDK by updating overrides to force patched transitive dependency versions, restoring clean npm audit results and keeping the TS build/test pipeline green.
Changes:
- Add npm
overridesforbrace-expansion,fast-uri, andjs-yamlto pull patched versions. - Refresh
package-lock.jsonto reflect the new resolved dependency graph (including updated resolved versions and metadata).
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| typescript/package.json | Adds overrides to force patched transitive dependency versions to satisfy npm audit. |
| typescript/package-lock.json | Updates the lockfile to reflect the new override resolutions. |
Files not reviewed (1)
- typescript/package-lock.json: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jeremy
added a commit
to robzolkos/basecamp-sdk
that referenced
this pull request
Jul 22, 2026
…reate-bucket-scope-20260601145434 * origin/main: (28 commits) Upstream sync: repin provenance to bc3 ba105ba7 (2026-07-22), register post-train contracts, codify pin semantics (basecamp#390) ci: pin conformance uv sync to the matrix Python; parse the fan-in gate (basecamp#388) BC5 readiness: pairwise BC4↔BC5 + check-bc5-compat orchestrator + scheduled CI (basecamp#308) CI: fold conformance suites into their language test jobs (basecamp#387) Fix TypeScript SDK Content-Type on GET requests (basecamp#384) BC5 launch reconciliation: registry refresh for the shipped BC5 API train (basecamp#325) BC5 readiness: cross-language wire-replay decoders (basecamp#301) BC5 readiness: Go wrapper forward-compat audit + field-level drift check (basecamp#309) BC5 readiness: TypeScript live wire-capture canary (basecamp#294) BC5 readiness: forward-compat spec, briefs, parity lint (basecamp#293) deps(ts): bump brace-expansion from 5.0.2 to 5.0.7 in /typescript (basecamp#386) typescript: bump fast-uri, brace-expansion, js-yaml overrides for fresh advisories (basecamp#385) deps(actions): bump the actions group with 6 updates (basecamp#382) deps(ruby): bump the bundler-dependencies group in /ruby with 2 updates (basecamp#379) deps(kotlin): bump the gradle-dependencies group (basecamp#383) deps(go): bump github.com/oapi-codegen/oapi-codegen/v2 in /go (basecamp#381) deps(ts): bump the npm-dependencies group in /typescript with 2 updates (basecamp#380) deps(smithy): bump the smithy-gradle-dependencies group (basecamp#378) deps(go): bump github.com/oapi-codegen/runtime (basecamp#377) Todos Update/Edit/Replace: merge-safe writes across all 6 SDKs (basecamp#375) ... # Conflicts: # go/pkg/basecamp/api-provenance.json # go/pkg/basecamp/version.go # go/pkg/generated/client.gen.go # kotlin/sdk/src/commonMain/kotlin/com/basecamp/sdk/BasecampConfig.kt # openapi.json # python/src/basecamp/_version.py # ruby/lib/basecamp/generated/metadata.json # ruby/lib/basecamp/generated/types.rb # ruby/lib/basecamp/version.rb # spec/api-provenance.json # spec/basecamp.smithy # swift/Sources/Basecamp/BasecampConfig.swift # typescript/src/client.ts # typescript/src/generated/metadata.ts # typescript/src/generated/openapi-stripped.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm Audit (TypeScript SDK) is red on every PR since three high-severity advisories published after the last green security run (2026-07-20):
^4.3.0to stay on the 4.x line since js-yaml 5 is a major bump for openapi-typescript's transitive use)All three ride the existing
overridespattern intypescript/package.json.npm auditclean;make ts-check(build + vitest) green;ts-generate/ts-generate-servicesverified working under the new resolutions on the sibling branch.Note: the bc5-readiness stack root #293 carries this exact same change branch-side (it owns the override pattern via its earlier fast-uri pin). Identical content — whichever lands second merges cleanly. This standalone PR exists so main-based PRs (e.g. the TS Content-Type fix, dependabot PRs) can go green without waiting on the stack.
Summary by cubic
Fixes failing npm audit checks in the TypeScript SDK by overriding vulnerable transitive deps. Updates
fast-uri,brace-expansion, andjs-yamlto patched versions so PRs go green again.fast-urito >=3.1.3 to patch host confusion; resolves to 4.1.1.brace-expansionto >=5.0.7 to fix DoS via exponential expansion.js-yamlto ^4.3.0 to fix quadratic CPU issue; stay on 4.x (5.x is a major bump for transitive use).Written for commit b1e2d22. Summary will update on new commits.