Repin bc3 provenance ca1d34bc → d7bc88da (no-op range) + fix two stale api-gaps entries#416
Repin bc3 provenance ca1d34bc → d7bc88da (no-op range) + fix two stale api-gaps entries#416jeremy wants to merge 1 commit into
Conversation
github-actions
Bot
added
typescript
Spec Change Impact
Checklist of SDKs needing updates:
|
There was a problem hiding this comment.
Pull request overview
Repins the upstream BC3 provenance revision (keeping the same provenance date) and refreshes SDK metadata outputs, while correcting two spec/api-gaps entries whose upstream documentation/behavior tails have closed.
Changes:
- Advance provenance revision
ca1d34bc… → d7bc88da…(date unchanged:2026-07-24), propagating into bothspec/and Go’s embedded provenance copy. - Update
spec/api-gaps/dock-tool-create-contract.mdto record bc3#12366 as the doc-tail closure and addbc3_pr: 12366. - Update
spec/api-gaps/schedule-recurrence-writes.mdto reflect that bc3#12362 merged and now rejectsweek_instance: 0server-side.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| typescript/src/generated/metadata.ts | Regenerated TS metadata timestamp (no functional change). |
| spec/api-provenance.json | Update BC3 provenance revision to d7bc88da… (date unchanged). |
| spec/api-gaps/schedule-recurrence-writes.md | Document server-side rejection for uncomputable recurrences (week_instance: 0). |
| spec/api-gaps/README.md | Update README provenance-pin narrative to the new revision/range. |
| spec/api-gaps/dock-tool-create-contract.md | Record upstream doc-tail closure (bc3#12366) and add bc3_pr. |
| ruby/lib/basecamp/generated/types.rb | Regenerated Ruby types header timestamp (no functional change). |
| ruby/lib/basecamp/generated/metadata.json | Regenerated Ruby metadata timestamp (no functional change). |
| go/pkg/basecamp/api-provenance.json | Update embedded Go provenance copy to d7bc88da…. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 461623af3c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| > Provenance pin advanced to `d7bc88da` (2026-07-24). The `ca1d34bc..d7bc88da` | ||
| > range — 30 commits — is a reviewed no-op for the SDK: 26 UI/CSS/JS/lexxy | ||
| > commits, plus the duplicate-cookie migration auth commits (`88cb86d2a`, | ||
| > `52f1e9974`, `7d86f1d06`) that touch only |
There was a problem hiding this comment.
The audit says this range contains 30 commits, but its breakdown accounts for only 29: 26 UI/CSS/JS/lexxy commits plus the three listed auth commits. Because the conformance pin may advance only after every drift item is triaged, the unclassified commit leaves the new pin unsupported; classify the remaining commit or correct the count before declaring the range a no-op.
AGENTS.md reference: AGENTS.md:L270-L274
Useful? React with 👍 / 👎.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 8 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
…e api-gaps entries Advance the bc3 provenance pin from ca1d34bc to d7bc88da (bc3 master at 2026-07-24). The ca1d34bc..d7bc88da range is 30 commits, all reviewed no-ops for the SDK: 26 UI/CSS/JS/lexxy commits plus the duplicate-cookie migration auth commits (88cb86d2a/52f1e9974/7d86f1d06), which touch only the by_cookie session-cookie concern and its test — no route, controller, doc, or modeled API-contract change. Pin date is unchanged (2026-07-24), so no SDK version bump. Also correct two api-gaps entries whose upstream tails have since closed: - dock-tool-create-contract: bc3#12366 (8f938281) rewrote doc/api/sections/tools.md for the tool_type contract, closing the doc tail the entry still tracked as the open bc3#12364 note. Add top-level bc3_pr: 12366. - schedule-recurrence-writes: bc3#12362 (ec17b83c) merged and now rejects week_instance: 0 (and other uncomputable schedules) at create time, so the mandatory SDK-side guard is downgraded to optional hygiene.
461623a to
32b7e1a
Compare
github-actions
Bot
added
swift
bug
| "DeleteTemplate", | ||
| "DeleteTool", | ||
| "DeleteWebhook", | ||
| "DeleteWormhole", | ||
| "DestroyGaugeNeedle", |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32b7e1a71d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| computed") merged and now rejects `week_instance: 0` (and other | ||
| uncomputable schedules) at create time — previously it spun a worker | ||
| indefinitely. An SDK-side guard is therefore **no longer mandatory**; `0` | ||
| is a normal validation error on the wire, not a hang. Modeling `frequency` |
There was a problem hiding this comment.
The newly documented rejection contradicts the contract summary above, which still says that any invalid recurrence_schedule is silently discarded with no validation error. When the planned PR-5 models error behavior, these two rules give implementers and tests incompatible expectations; qualify the earlier bullet so silent discard applies only to invalid shapes other than the uncomputable schedules rejected by #12362.
Useful? React with 👍 / 👎.
Summary
Advance the bc3 provenance pin from
ca1d34bc→d7bc88da(bc3masterat 2026-07-24), and correct twospec/api-gaps/*.mdentries whose upstream tails have since closed.This is PR-0 of the multi-PR program absorbing the remaining BC3 follow-up contracts. It is a standalone provenance sync, warranted independent of the absorptions that follow.
Provenance range: reviewed no-op
ca1d34bc..d7bc88da= 30 commits, all non-API:88cb86d2a,52f1e9974,7d86f1d06), which touch onlyapp/controllers/concerns/authenticate/by_cookie.rb(a session-cookie concern) and its test — no route, controller, doc, or modeled API-contract change.Pin date is unchanged (2026-07-24), so no SDK version bump. Only the provenance revision propagates into the go:embed; the other generated diffs are the usual generation-timestamp bumps.
Two stale api-gaps corrections (dropped during #401 reconciliation)
dock-tool-create-contract.md— bc3#12366 (8f938281) rewrotedoc/api/sections/tools.mdfor thetool_typecontract, closing the doc tail this entry still tracked as the open bc3#12364 note. Adds top-levelbc3_pr: 12366.schedule-recurrence-writes.md— bc3#12362 (ec17b83c) merged and now rejectsweek_instance: 0(and other uncomputable schedules) at create time, so the previously-mandatory SDK-side guard is downgraded to optional hygiene.Verification
make generate && make check— clean (71 conformance passed, 0 failed; 23 api-gap entries validated; deprecation parity clean).Summary by cubic
Repins BC3 API provenance to d7bc88da (master at 2026-07-24) and refreshes generated metadata. Range reviewed as a no-op for the SDK (no API contract changes), so no SDK version bump.
tool_typecontract and closes the old tracking note.week_instance: 0at create time, so the SDK-side guard is optional hygiene.Written for commit 32b7e1a. Summary will update on new commits.