Skip to content

Go: replay *WithBody request bodies across retries #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremy merged 1 commit into from
Jul 28, 2026
Merged

Go: replay *WithBody request bodies across retries #481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions go/pkg/basecamp/account_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,15 +218,15 @@ func (s *AccountService) UpdateLogo(ctx context.Context, logo io.Reader, filenam
}

// Delegate to the generated client — retry and auth are handled by the transport.
// Pass a rewindable reader so doWithRetry can replay the body on transient failures.
// Pass a *bytes.Reader so net/http snapshots it into GetBody and doWithRetry
// can replay the body on transient failures.
bodyBytes := buf.Bytes()
multipartContentType := writer.FormDataContentType()
rewindable := &rewindableReader{data: bodyBytes}
resp, err := s.client.parent.gen.UpdateAccountLogoWithBodyWithResponse(
ctx,
s.client.accountID,
multipartContentType,
rewindable,
bytes.NewReader(bodyBytes),
)
if err != nil {
return err
Expand Down
Loading
Loading