Skip to content

Document how a sync PR differs from an off-target direct edit#417

Merged
jeremy merged 1 commit into
masterfrom
document-sync-pr-vs-direct-edit
Jul 23, 2026
Merged

Document how a sync PR differs from an off-target direct edit#417
jeremy merged 1 commit into
masterfrom
document-sync-pr-vs-direct-edit

Conversation

@jeremy

@jeremy jeremy commented Jul 23, 2026

Copy link
Copy Markdown
Member

Automated reviewers keep flagging legitimate sync PRs as unauthorized direct edits to sections/ — because a sync PR and a hand-edit look identical in the diff, and AGENTS.md only said "don't edit docs here" without carving out that syncs are the sanctioned path.

This adds a short Sync PRs are expected — off-target edits are not subsection that:

  • States the invariant: every PR touching README.md, CONDUCT.md, or a sections/*.md file is sync output from script/api/sync_to_bc3_api — the only way that content changes — so reviewers should read the docs on their merits, not flag the mechanism.
  • Defines the recognizable marker: sync PRs carry a Synced from bc3 doc/api/ … footer in their description; an off-target edit has no footer and won't match bc3's doc/api/.
  • Notes the exception: a PR touching only this file or GitHub metadata (which the sync doesn't copy) is edited here directly and carries no footer — as this PR does.

Docs/guidance only.

Copilot AI review requested due to automatic review settings July 23, 2026 02:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds reviewer-facing guidance to AGENTS.md clarifying how to distinguish sanctioned documentation sync PRs from off-target hand-edits, reducing false-positive review feedback in this docs-mirror repository.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

Changes:

  • Document that docs changes are expected to arrive via script/api/sync_to_bc3_api sync PRs (and how to recognize them via the PR description footer).
  • Define “off-target edits” and call out the exception for repo-local files/GitHub metadata that are not copied by the sync.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread AGENTS.md Outdated
Copilot AI review requested due to automatic review settings July 23, 2026 04:55
@jeremy
jeremy force-pushed the document-sync-pr-vs-direct-edit branch from 0a8158f to 7d3f0b3 Compare July 23, 2026 04:55
@jeremy
jeremy merged commit 074d000 into master Jul 23, 2026
1 check passed
@jeremy
jeremy deleted the document-sync-pr-vs-direct-edit branch July 23, 2026 04:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants