Docs: skills-sync App needs Contents + Issues write - #59
Merged
Conversation
The workflow requests permission-contents and permission-issues, and the pinned create-github-app-token fails token creation outright when a requested permission is missing from the installation — a Contents-only App stops syncing entirely after #58. Document both permissions and the installation-update reapproval for existing Apps.
There was a problem hiding this comment.
Pull request overview
Updates the seeded release and bootstrap documentation to reflect the current permissions required by the skills-sync GitHub App token workflow, preventing existing “Contents-only” app installations from breaking sync when the workflow requests additional scopes.
Changes:
- Document that the skills-sync App installation must grant Contents: write and Issues: write on
basecamp/skills. - Add guidance that existing installations may require permission updates and re-approval for sync to work again.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| seed/RELEASING.md.tmpl | Adds explicit required skills-sync App permissions and notes about updating existing installations. |
| prompts/seed-cli.md | Updates the post-bootstrap “Secrets & vars” matrix row to include the required App permissions and failure mode. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #58 closing its post-merge review thread: the seeded docs told users to configure only the App ID and private key, but the workflow now requests
permission-contents+permission-issues, and the pinned create-github-app-token fails token creation when a requested permission is missing from the installation — so an existing Contents-only App stops syncing entirely. Documents both required permissions onbasecamp/skillsand the installation-update reapproval for existing Apps, inseed/RELEASING.md.tmplandprompts/seed-cli.md.