Bare pin comments: let Dependabot maintain action version comments - #192
Merged
Conversation
…n comments Dependabot rewrites bare version comments natively but cannot touch compound ones carrying a trailing zizmor ignore. One line per pin plus a standalone ignore below it (same restructure as basecamp-sdk#458) makes Dependabot the first line of defense with no push automation needed on its PRs. Also normalizes zizmor-action to v0.6.0 so the audit runs a zizmor that associates standalone ignore comments (the 1.23-era resolution of older action versions does not).
Sensitive Change Detection (shadow mode)This PR modifies control-plane files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the release GitHub Actions workflow to make action pin version comments “bare” so Dependabot can maintain them automatically, while keeping zizmor ignores intact on their own line.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Changes:
- Split the inline compound comment on
actions/setup-gointo a standalone# vX.Y.Zpin comment and a separate# zizmor: ignore[...]line. - Preserve the existing zizmor ignore reason text without altering the pinned SHA.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot rewrites bare
# vX.Y.Zcomments on pinneduses:lines natively but cannot touch compound ones carrying a trailing# zizmor: ignore[...]. Moving each ignore to its own line directly below the pin (reason text kept, association verified under zizmor 1.28) makes Dependabot itself the comment maintainer — no push automation required on its PRs. Same restructure basecamp-sdk shipped in basecamp-sdk#458. Part of the post-merge redesign of the comment-sync program (see basecamp/.github#10 for why in-PR pushing is unsafe: a deploy-key push flips the run actor off dependabot[bot] and lifts the Dependabot sandbox for the unreviewed bumped actions).Summary by cubic
Move
zizmorignores to their own lines under pinneduses:steps so Dependabot can maintain the bare# vX.Y.Zcomments without push automation. In.github/workflows/release.yml, split the trailing ignore from theactions/setup-gopin (# v7.0.0) into a standalone line directly below it.Written for commit 74a49fa. Summary will update on new commits.