Fix database CI failures - #58
Merged
Merged
Conversation
MySQL and Postgres services had no health checks, causing db:setup to run before the databases were ready to accept connections. Also set fail-fast: false so all matrix jobs run to completion. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR addresses intermittent database-related CI failures by ensuring Postgres/MySQL service containers are healthy before Rails DB setup runs, and by making the matrix execute all variants even if one fails.
Changes:
- Disable matrix
fail-fastso sqlite/postgres/mysql jobs complete independently. - Add Docker health checks for Postgres and MySQL GitHub Actions service containers.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
db:setupfail-fast: falseso all matrix jobs run to completion even if one failsTest plan
🤖 Generated with Claude Code