Make the services definition path env-overridable#97
Open
lewispb wants to merge 1 commit into
Open
Conversation
Add Upright.config.services_path (defaults to config/services.yml), and have Upright::Service read from it. Lets a host point staging at a different services file so the public status page reflects the environment's probe set, mirroring probes_path. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Upright.config.services_path(defaults toconfig/services.yml) and hasUpright::Serviceread from it, mirroringprobes_path. This lets a host point a given environment at a different services file so the public status page reflects that environment's actual probe set.Backward-compatible: the default is unchanged, so existing installs (and the dummy app) behave exactly as before.
Paired with 37upright's
staging-services-configbranch, which setsservices_pathto a staging-only services file.🤖 Generated with Claude Code