Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions alembic/versions/f593c35b86e7_feedback_ratings_non_nullable.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
"""Make feedback ratings non-nullable.

Revision ID: f593c35b86e7
Revises: c0135b4524b9
Create Date: 2026-02-05 17:05:51.285336
"""

from typing import Sequence, Union

import sqlalchemy as sa
from alembic import op

# revision identifiers, used by Alembic.
revision: str = "f593c35b86e7"
down_revision: Union[str, Sequence[str], None] = "c0135b4524b9"
branch_labels: Union[str, Sequence[str], None] = None
depends_on: Union[str, Sequence[str], None] = None


def upgrade() -> None:
"""Upgrade schema."""
op.alter_column("feedback", "rating", existing_type=sa.INTEGER(), nullable=False)


def downgrade() -> None:
"""Downgrade schema."""
op.alter_column("feedback", "rating", existing_type=sa.INTEGER(), nullable=True)
2 changes: 1 addition & 1 deletion app/db/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ class FeedbackSyncStatus(str, Enum):


class FeedbackPayload(SQLModel):
rating: FeedbackRating = Field(sa_column=Column(Integer))
rating: FeedbackRating = Field(sa_column=Column(Integer, nullable=False))
comments: str | None = Field(default=None)


Expand Down