Skip to content

Fix gh helper output variable shadowing#123

Merged
codeforester merged 1 commit into
mainfrom
fix/122-20260706-gh-output-shadowing
Jul 6, 2026
Merged

Fix gh helper output variable shadowing#123
codeforester merged 1 commit into
mainfrom
fix/122-20260706-gh-output-shadowing

Conversation

@codeforester

Copy link
Copy Markdown
Collaborator

Summary

  • fix gh_detect_default_branch and gh_repo_default_branch pass-by-name shadowing
  • add regression coverage for callers that use default_branch as the result variable name

Fixes #122

Validation

  • RED: bats lib/bash/gh/tests/lib_gh.bats failed on the new default_branch result-variable regression tests
  • bats lib/bash/gh/tests/lib_gh.bats
  • tests/lint-warnings.sh
  • git diff --check
  • tests/validate.sh

@codeforester codeforester merged commit d62e8c1 into main Jul 6, 2026
2 checks passed
@codeforester codeforester deleted the fix/122-20260706-gh-output-shadowing branch July 6, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix gh helper output-variable shadowing

1 participant