Skip to content

Use shared file section helpers in update-profile#1513

Merged
codeforester merged 1 commit into
mainfrom
refactor/1492-20260706-update-profile-helpers
Jul 7, 2026
Merged

Use shared file section helpers in update-profile#1513
codeforester merged 1 commit into
mainfrom
refactor/1492-20260706-update-profile-helpers

Conversation

@codeforester

Copy link
Copy Markdown
Collaborator

Summary

  • Replace update_profile.sh's local marker-count and section-content temp-file comparison with shared base-bash-libs file section helpers.
  • Add an import capability check for file_section_exists and file_section_needs_update so older helper checkouts fail clearly.
  • Pin CI to base-bash-libs commit 424ef9fe61bc8a462ba9980ea63b38dd202ec242, which landed the companion helper PR.

Companion helper PR: basefoundry/base-bash-libs#124.

Fixes #1492.

Validation

  • RED: env BASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash bats --filter "shared file section helper" cli/bash/commands/basectl/tests/update-profile.bats failed before implementation because the shared helper stubs were not called.
  • PASS: env BASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash bats --filter "shared file section helper" cli/bash/commands/basectl/tests/update-profile.bats
  • PASS: env BASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash bats cli/bash/commands/basectl/tests/update-profile.bats
  • PASS: bash -n cli/bash/commands/basectl/subcommands/update_profile.sh cli/bash/commands/basectl/tests/update-profile.bats
  • PASS: shellcheck -S warning cli/bash/commands/basectl/subcommands/update_profile.sh cli/bash/commands/basectl/tests/update-profile.bats
  • PASS: env PYTHONPATH=lib/python:cli/python $HOME/.base.d/base/.venv/bin/python -m pytest tests/test_github_workflows.py
  • PASS: git diff --check
  • PASS: env -u BASE_HOME BASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash BASE_CACHE_DIR=/private/tmp/base-pr-train-1492 ./bin/base-test

@codeforester codeforester requested a review from a team as a code owner July 7, 2026 03:23
@codeforester codeforester merged commit 0533292 into main Jul 7, 2026
26 checks passed
@codeforester codeforester deleted the refactor/1492-20260706-update-profile-helpers branch July 7, 2026 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Finish update-profile file-helper adoption

1 participant