fix #3192 【カスタムコンテンツ：フィールド：5.1】（都道府県リスト）プレビュー操作不具合#4413
Open
kaburk wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
カスタムコンテンツの「都道府県リスト」フィールド（BcCcPref）のプレビュー画面で、初期値の反映・編集が正しく動作しない問題（#3192）を修正し、あわせて関連テストを追加するPRです。副次的に、二段階認証コード検証テストの実行安定性を高めています。
Changes:
- BcCcPref のプレビュー用フォーム属性を
:valueからv-modelに変更し、Vue 側の双方向バインディングで初期値が扱えるように修正 - 上記の挙動を検証する BcCcPrefHelper のテストを追加
- TwoFactorAuthenticationsService の検証テストで
BcApp.twoFactorAuthenticationCodeAllowTimeを一時的に固定し、テスト間干渉を回避
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| plugins/bc-custom-content/tests/TestCase/View/Helper/BcCcPrefHelperTest.php | BcCcPref のプレビューHTMLに v-model が出力されることを確認するテストを追加 |
| plugins/bc-custom-content/plugins/BcCcPref/src/View/Helper/BcCcPrefHelper.php | プレビュー時の属性を v-model="entity.default_value" に変更し、プレビュー操作不具合を修正 |
| plugins/baser-core/tests/TestCase/Service/TwoFactorAuthenticationsServiceTest.php | 検証テスト中のみ許容時間設定を固定し、グローバル設定の影響を受けにくくする |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
よろしくお願いします。