Migrate from Travis CI to Github actions#36
Open
ahmagdy wants to merge 4 commits intobashmohandes:masterfrom
Open
Migrate from Travis CI to Github actions#36ahmagdy wants to merge 4 commits intobashmohandes:masterfrom
ahmagdy wants to merge 4 commits intobashmohandes:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate build validation steps from Travis CI to Github actions.
I used two separate jobs for Linux and macOS instead of using matrix strategy as there is no docker by default in macOS. Therefore I can't run Postgres service, and I can't add a condition to exclude this service. Conditions are only supported for steps and not for services!
It's very annoying that I had to duplicate go build and test steps because there are no composite actions in Github yet. It's being tracked in actions/runner#646.
The workflow has been tested in https://github.com/ahmagdy/go-askme/actions/runs/627285467.