Template docker by TheoMeunier · Pull Request #87 · bastien70/dbsaver

TheoMeunier · 2023-05-17T19:24:50Z

hi,

I propose you a complete docker stack for this project that I have set up on a production server and it is very stable.

I propose you to update it regularly according to the improvement of the project

I hope you will like it and don't need to come to me if you want other functionalities
;)

bastien70

Hey! Thank you for this great contribution! It is indeed something that we would like to have :)

I did a first review. For things a little more technical, I let Jmsche go over it

bastien70 · 2023-05-19T08:19:08Z

+# IMPORTANT: You MUST configure your server version, either here or in config/packages/doctrine.yaml
+#
+#DATABASE_URL="sqlite:///%kernel.project_dir%/var/dbsaver.db"
+DB_HOST=${APP_SLUG}_database


Not sure if the '_database' suffix is needed here since it can only be that if I'm not mistaken. It would be redundant. @jmsche ?

the suffix '_database' is necessary because it is the no of the container. you can find them in the docker-compose: https://github.com/TheoMeunier/dbsaver/blob/main/docker-compose.yaml#L37

Can you rename this to .env.example?

bastien70 · 2023-05-19T08:20:39Z

+.idea
+.vscode


This should be part of your global .gitignore, not put in all your projects. Take a look on https://gist.github.com/subfuzion/db7f57fff2fb6998a16c

I can confirm these should not be listed in this file.

bastien70 · 2023-05-19T08:22:34Z

Maybe add a "Docker installation guide" :)

Perfect I will make a doc to see explain the installation of docker on debian and ubuntu.
What format did you want the guide in?
in the README.md

Just to be sure, I'm talking about the installation via docker of the application and not the installation of Docker in general :) (I think you had understood)

You can put that under "Installation with Task" (or that of the maker).

A very simple trick will do, it's just to signal that they can use Docker. Besides, I'm not a Docker pro. Did you set up something in the docker script to initialize the application for the 1st time, or do you have to run "task install" or "make install" before?

We can do the installation of the project via "make install" or "task install" or via docker commands. So I will add the installation process via docker simply. Do you want me to update also the installation with tack to use docker?

The implementation of docker was created using my template where we can find all the information for the installation, which I could implement in this project ;)

Afterwards I could create a docker image for the whole application if the docker stack will suit you.

https://github.com/TheoMeunier/symfony-template

Yes you can add it on the Task file too ;)

Wow, a docker image would be awesome!

I let @jmsche for the end of the review :)

jmsche · 2023-05-22T09:37:53Z

+# IMPORTANT: You MUST configure your server version, either here or in config/packages/doctrine.yaml
+#
+#DATABASE_URL="sqlite:///%kernel.project_dir%/var/dbsaver.db"
+DB_HOST=${APP_SLUG}_database


Can you rename this to .env.example?

jmsche · 2023-05-22T09:38:22Z

+DB_PASSWORD=root
+DB_ROOT_PASSWORD=root
+DATABASE_URL="mysql://dbsaver:root@${APP_SLUG}_database:3306/dbsaver"
+#DATABASE_URL="postgresql://db_user:db_password@127.0.0.1:5432/db_name?serverVersion=13&charset=utf8"


You can remove this line, Postgres is not officially supported by this app.

jmsche · 2023-05-22T09:38:40Z

+# Format described at https://www.doctrine-project.org/projects/doctrine-dbal/en/latest/reference/configuration.html#connecting-using-a-url
+# IMPORTANT: You MUST configure your server version, either here or in config/packages/doctrine.yaml
+#
+#DATABASE_URL="sqlite:///%kernel.project_dir%/var/dbsaver.db"


You can remove this line, sqlite is not officially supported by this app.

jmsche · 2023-05-22T09:39:08Z

+.idea
+.vscode


I can confirm these should not be listed in this file.

jmsche · 2023-05-22T09:39:26Z

+.vscode

 ###> symfony/framework-bundle ###
+/.env


As this app is primarily a Symfony app, the .env file should be versioned.

jmsche · 2023-05-22T09:48:57Z

+    libpng-dev \
+    libjpeg62-turbo-dev \
+    libfreetype6-dev \
+    libxslt-dev \
+    locales \
+    zip \
+    jpegoptim optipng pngquant gifsicle \
+    vim \
+    unzip \
+    git \
+    curl \
+    nodejs


Some packages should be removed from this list.

jmsche · 2023-05-22T09:49:18Z

+RUN apt-get clean && rm -rf /var/lib/apt/lists/*
+
+# Install extensions
+RUN docker-php-ext-install pdo pdo_mysql xsl intl gd


Are xsl & gd really necessary?

yes, dependencies is realy neccessay for application, else symfony ask install

jmsche · 2023-05-22T09:49:41Z

+    # add_header X-XSS-Protection "1; mode=block";
+    # add_header X-Content-Type-Options "nosniff";


jmsche · 2023-05-22T09:49:54Z

@@ -0,0 +1,32 @@
+server {
+    listen 80 default;
+    client_max_body_size 308M;


jmsche · 2023-05-22T09:50:46Z

+    # PHP Service
+    php:
+        build:
+            context: .
+            dockerfile: docker/php/Dockerfile
+        container_name: ${APP_SLUG}_php
+        restart: unless-stopped
+        environment:
+            SERVICE_NAME: ${APP_SLUG}_php
+            SERVICE_TAGS: ${APP_ENV}
+        working_dir: /var/www
+        volumes:
+            - ./:/var/www
+            - ./docker/php/local.ini:/usr/local/etc/php/conf.d/local.ini
+        networks:
+            - app_network
+
+    # Nginx Service
+    nginx:
+        image: nginx:alpine
+        container_name: ${APP_SLUG}_nginx
+        restart: unless-stopped
+        ports:
+            - "8888:80"
+        volumes:
+            - ./:/var/www
+            - ./docker/nginx/nginx.conf:/etc/nginx/conf.d/default.conf
+        networks:
+            - app_network


I'm not sure I want to include PHP & nginx in the general Docker compose configuration. Maybe this could be moved to a docker-compose.prod.yaml file instead?

you prefer using symfony cli for dev ?I don't care about that

TheoMeunier · 2023-08-15T18:02:09Z

Hi,

I'll get back to you to find out what you think of my proposal for a docker application.
what are the points to improve on my side for my PR to be accepted, I like to work a little for open source and propose a docker version could be really nice

Isox

jmsche · 2023-08-16T09:02:28Z

Hi, there are still many points to fix according to latest review. Also, you should rebase the current main branch on yours to allow merging the PR.

TheoMeunier · 2023-08-20T20:08:05Z

Hello, I have fixed the modifications as well as the things to be fixed. Would there be other things to bring or to modify?

TheoMeunier

Hello, j'ai mit à jours le projet de Bastien sur mon fork. Ainsi j'ai mis au propre mes modificatios.

TheoMeunier · 2023-08-20T19:46:21Z

+
+# Install extensions
+RUN docker-php-ext-install pdo pdo_mysql xsl intl gd
+RUN npm install -g -y yarn


we would need to install the dependencies in the docker container so we need to compose

TheoMeunier · 2023-08-20T19:55:48Z

+# Get nodejs
+RUN curl -fsSL https://deb.nodesource.com/setup_lts.x | bash -


Why removed composer ?

TheoMeunier · 2023-08-20T20:01:01Z

@@ -0,0 +1,10 @@
+date.timezone=Europe/Berlin
+memory_limit=512M


it's the memory limit of the application, do you want me to decrease it?

TheoMeunier added 3 commits May 17, 2023 21:10

fix: add full stack docker and make file for using in Dockerfile

be226a3

feat: add docker compose for dev

ede3d9d

fix: clear code

7a4c367

bastien70 requested changes May 19, 2023

View reviewed changes

TheoMeunier added 5 commits May 19, 2023 11:15

fix: connection db in prod

c26c5f5

fix: configuration proxy reverse

36dae39

fix: navigation README.md

613a31d

feat: add documentation for installation with docker

b65df41

feat: task installation with docker

130ac26

jmsche requested changes May 22, 2023

View reviewed changes

TheoMeunier added 4 commits May 22, 2023 18:43

fix: clear .env

67ae843

fix: clear conf nginx

32e9752

fix: clear dependencies dockerfile

ef9ec3a

fix: remove service php and nginx in dev. Add docker-compose.prod.yaml

ec93f23

TheoMeunier added 9 commits August 20, 2023 21:50

fix: clear .gitignore

5191a77

fix: add versioning file .env

b0145b7

fix: deleting makefile for create PR

f6ee842

fix: timezone for local.ini

a264bd3

dix: delete nodejs in dockerfile

bc1209f

fix: delete nodejs in dockerfile

1688e43

migration: php8.1 to php8.2

6b1b537

fix: cleat conf nginx

c88dd17

fix: using docker for prod and not default

7f97fd5

TheoMeunier requested a review from bastien70 December 30, 2023 16:54

TheoMeunier and others added 2 commits December 30, 2023 17:55

Merge branch 'bastien70:main' into main

1f94792

fix: implementation docker using dbsaber in prod

8fbb7e1

TheoMeunier requested a review from jmsche December 30, 2023 22:16

TheoMeunier commented Dec 30, 2023

View reviewed changes

		# add_header X-XSS-Protection "1; mode=block";
		# add_header X-Content-Type-Options "nosniff";

		# Get nodejs
		RUN curl -fsSL https://deb.nodesource.com/setup_lts.x \| bash -

		@@ -0,0 +1,10 @@
		date.timezone=Europe/Berlin
		memory_limit=512M

		.idea
		.vscode

		.idea
		.vscode

Conversation

TheoMeunier commented May 17, 2023

Uh oh!

bastien70 left a comment

Choose a reason for hiding this comment

Uh oh!

bastien70 May 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TheoMeunier May 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TheoMeunier May 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TheoMeunier commented Aug 15, 2023

Uh oh!

jmsche commented Aug 16, 2023

Uh oh!

TheoMeunier commented Aug 20, 2023

Uh oh!

TheoMeunier left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bastien70 May 19, 2023 •

edited

Loading

TheoMeunier May 19, 2023 •

edited

Loading

TheoMeunier May 19, 2023 •

edited

Loading