WIP: Kimai2 conversion#8
Open
bastilimbach wants to merge 8 commits intomasterfrom
Open
Conversation
bastilimbach
commented
Sep 23, 2018
| let user = User(userName: userName, apiEndpoint: apiEndpoint, apiKey: result.apiKey) | ||
| switch result { | ||
| case .success(let ping): | ||
| if ping.message == "pong" { |
Owner
Author
There was a problem hiding this comment.
Change to: ping.version >= 0.1
Owner
Author
|
@kevinpapst is it possible to add a default API password to all demo users of the demo instance? Then I could use this instance with the user "john_user" for everybody who wants to test Timeu without the need to install their own Kimai instance. |
|
That is already the case, use |
Owner
Author
|
The login now works with the new |
|
Nice! I'll will work on that directly after finishing all currently open PRs. |
2 tasks
|
Sorry, I had to change the version to string, otherwise something like "0.6.1" wouldn't be possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress PR for the conversion of the legacy API.
Login
Timesheet