Replaced destructor with Dispose(), and added InvalidOperationExcept…#1
Open
jacobvc wants to merge 1 commit intobatourin:mainfrom
Open
Replaced destructor with Dispose(), and added InvalidOperationExcept…#1jacobvc wants to merge 1 commit intobatourin:mainfrom
jacobvc wants to merge 1 commit intobatourin:mainfrom
Conversation
…ion catch. The destructor was never reached because the thread it was intended to cancel never ended. The OperationCancelledException was apparently changed to an invalid operation by an intervening object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In trying to use this library (in a windows Forms app) It hung on exit.
I determined that ViscaProtocolProcesser was blocked on close by the parseResponse thread that the destructor would have cancelled.
I was able to solve the issue by change the destructor to Dispose().
Once that was done, it failed with an InvalidOperationException. The OperationCancelledException was apparently changed to an invalid operation by an intervening object. Rather than mess with deeper code, I added a handler as a temporary solution for my problem.
I hope this is helpful.