Skip to content

Add feature for * in toolchains_aspects #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fmeum merged 4 commits into from
Jul 6, 2026
Merged

Add feature for * in toolchains_aspects #150

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5de1623
Support for * in toolchains_aspects
darkrift Jul 4, 2026
a8bd819
Apply suggestion from @fmeum
fmeum Jul 6, 2026
470576c
Move feature to rules
darkrift Jul 6, 2026
982d773
keep internal feature last
darkrift Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions features.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ _cc = struct(
# Internal only, don't use outside rules_cc.
# https://github.com/bazelbuild/bazel/commit/d788aa269a3300771696a0f9e00868a43cadf7d3
_get_link_args_has_param_file_name = ge("10.0.0-pre.20260608.1"),

)

_docs = struct(
Expand Down Expand Up @@ -194,7 +193,12 @@ _rules = struct(
# https://github.com/bazelbuild/bazel/commit/a59ad366453bb731b255916277d34d5d536ca696
constraint_setting_has_refines_constraint_value = gt("10.0.0-pre.20260524.1"),

# Internal only, don't use outside rules_java, rules_python & rules_shell.
# Whether toolchains_aspects accept "*" to propagate to all toolchains
# 8.8.0 : https://github.com/bazelbuild/bazel/commit/dd6a292e2b160bbd35b9d9b67d21971f4efeb94c
# 9.2.0+ : https://github.com/bazelbuild/bazel/commit/584eeed4de4e0c76e451d0212ab582e2109ceacb
supports_toolchains_aspects_star = ge_same_major("8.8.0") or ge("9.2.0rc1"),
Comment thread
fmeum marked this conversation as resolved.

# Internal only and keep last, don't use outside rules_java, rules_python & rules_shell.
# TODO: Use a larger version range after cherry-picking
# https://github.com/bazelbuild/bazel/commit/e81949554f3ecab5e2c4afd79031f498f36427fe
_has_launcher_maker_toolchain = ge_same_major("8.3.0") or ge("9.0.0-pre.20250516.1"),
Expand Down
Loading