Skip to content

Use a param file for multi_deploy merge inputs#576

Merged
malt3 merged 2 commits into
bazel-contrib:mainfrom
utkarsh-dd:codex/multi-deploy-param-file
Jun 25, 2026
Merged

Use a param file for multi_deploy merge inputs#576
malt3 merged 2 commits into
bazel-contrib:mainfrom
utkarsh-dd:codex/multi-deploy-param-file

Conversation

@utkarsh-dd

@utkarsh-dd utkarsh-dd commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Summary:

  • Spill multi_deploy's deploy-merge arguments into a Bazel multiline param file.
  • Expand @argfiles in img deploy-merge before flag parsing.
  • Add regression coverage for deploy-merge argfile handling.

Why:

  • Large multi_deploy targets can have thousands of operations.
  • Passing every deploy manifest path inline can exceed OS command-line limits.
  • Bazel param files are the standard way for rules to avoid long argv failures.

Notes:

  • The "deploy-merge" subcommand remains inline so the img dispatcher still works.
  • This follows the existing repo pattern of using Bazel Args param files for large action inputs, as seen in layer and layer_from_binary actions.
  • The public Starlark API is unchanged.
  • Prebuilt binaries are not patched in this PR; releases/toolchain packaging should pick up the source change normally.

@utkarsh-dd utkarsh-dd marked this pull request as ready for review June 25, 2026 02:16
Comment thread img/private/multi_deploy.bzl Outdated
@malt3 malt3 added this pull request to the merge queue Jun 25, 2026
Merged via the queue into bazel-contrib:main with commit 41b459a Jun 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants