image_layer: place a single file under a trailing-slash srcs key by b…#579
Merged
Conversation
…asename A srcs key ending in "/" denotes a directory. For a multi-output target the trailing slash was already normalized away, but a single-file src used the key verbatim as the tar entry name, which the layer tool rejected with "invalid node header: <path>/". Now a single file under a directory key is placed inside it by basename, matching the multi-file directory semantics (and layer_from_binary's trailing-slash path handling). Extends the tests/layering/testcases/trailing_slash case to cover a single file placed at a trailing-slash key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…asename
A srcs key ending in "/" denotes a directory. For a multi-output target the trailing slash was already normalized away, but a single-file src used the key verbatim as the tar entry name, which the layer tool rejected with "invalid node header: /". Now a single file under a directory key is placed inside it by basename, matching the multi-file directory semantics (and layer_from_binary's trailing-slash path handling).
Extends the tests/layering/testcases/trailing_slash case to cover a single file placed at a trailing-slash key.