fix: rules_mypy work on Bazel 9#129
Open
shayanhoshyari wants to merge 1 commit intobazel-contrib:mainfrom
Open
fix: rules_mypy work on Bazel 9#129shayanhoshyari wants to merge 1 commit intobazel-contrib:mainfrom
shayanhoshyari wants to merge 1 commit intobazel-contrib:mainfrom
Conversation
shayanhoshyari
commented
Dec 31, 2025
Author
|
cc: @markelliot |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
e2df9c7 to
dfa02d0
Compare
- Add CI for bazel 9. - Add a detection for if built-in PyInfo exists - In mypy.bzl only handle built-in PyInfo if it exists.
dfa02d0 to
a3c508c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Bazel 9 does not have any built in
PyInfoanymore. So our references to it failed. This PR fixes that.Changes:
bazel_features.Related issues:
--incompatible_autoload_externally=#102