Skip to content

fix: rules_mypy work on Bazel 9#129

Open
shayanhoshyari wants to merge 1 commit intobazel-contrib:mainfrom
shayanhoshyari:hoshyari/bazel-9
Open

fix: rules_mypy work on Bazel 9#129
shayanhoshyari wants to merge 1 commit intobazel-contrib:mainfrom
shayanhoshyari:hoshyari/bazel-9

Conversation

@shayanhoshyari
Copy link

@shayanhoshyari shayanhoshyari commented Dec 31, 2025

Summary: Bazel 9 does not have any built in PyInfo anymore. So our references to it failed. This PR fixes that.

Changes:

  • Add a detection for if built-in PyInfo exists. Used canonical bazel_features.
  • In mypy.bzl only handle built-in PyInfo if it exists.
  • Add bazel 9 to CI.

Related issues:

@shayanhoshyari shayanhoshyari changed the title fix: rules_mypy works on bazel 9 now fix: rules_mypy work on bazel 9 Dec 31, 2025
@shayanhoshyari shayanhoshyari changed the title fix: rules_mypy work on bazel 9 fix: rules_mypy work on Bazel 9 Dec 31, 2025
@shayanhoshyari
Copy link
Author

cc: @markelliot

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@shayanhoshyari shayanhoshyari force-pushed the hoshyari/bazel-9 branch 5 times, most recently from e2df9c7 to dfa02d0 Compare December 31, 2025 21:17
- Add CI for bazel 9.
- Add a detection for if built-in PyInfo exists
- In mypy.bzl only handle built-in PyInfo if it exists.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ruleset fails to build with --incompatible_autoload_externally=

1 participant