feat: use uv.lock deps for the dep graph instead - #4059
Draft
aignas wants to merge 1 commit into
Draft
Conversation
Summary: - Thread deps from uv.lock file into the hub_repository - Use them to define the dep graph - Alter the pkg_aliases and render_pkg_aliases to be able to use the dep graph information if it is provided. TODO: - [ ] Split the whl_library_targets into separate files, I think they have stabilized enough. - [ ] Have a separate PR just for threading the dependencies to render_pkg_aliases. We probably need to handle various edge-cases where we have different package versions in the uv.lock file. - [ ] Have a separate PR to enable usage of the dependency graph. This is now probably doing a few shortcuts. - [ ] If we have uv.lock, define fewer wheel repos - only define the sources without passing the dep_template in there. - [ ] Test coverage for the above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
to use the dep graph information if it is provided.
TODO:
have stabilized enough.
render_pkg_aliases. We probably need to handle various edge-cases
where we have different package versions in the uv.lock file.
is now probably doing a few shortcuts.
sources without passing the dep_template in there.
Creating the PR for discussion mainly. I am not sure when I'll get to do any of
the above, so if someone would like to start doing this along the similar lines
on how this PR has been designed, please feel free to take any part here.