agents(starlark): document depset element immutability and provider conventions - #4060
Merged
rickeylev merged 1 commit intoAug 16, 2026
Merged
Conversation
…onventions Depset elements and nested provider fields must be immutable upon depset construction in Bazel, and using providers rather than structs enables key sharing to minimize memory overhead. Documenting these invariants helps agents adhere to Bazel best practices and avoid runtime errors or buildifier lint warnings when working with custom providers in depsets. Update Starlark agent rules to require providers for depset elements, enforce tuple or depset types for nested fields instead of mutable lists, and document the buildifier suppression convention for non-Info providers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agents(starlark): document depset element immutability and provider conventions
Depset elements and nested provider fields must be immutable upon depset
construction in Bazel, and using providers rather than structs enables
key sharing to minimize memory overhead. Documenting these invariants
helps agents adhere to Bazel best practices and avoid runtime errors
or buildifier lint warnings when working with custom providers in
depsets.
Update Starlark agent rules to require providers for depset elements,
enforce tuple or depset types for nested fields instead of mutable
lists, and document the buildifier suppression convention for non-Info
providers.