Open
Conversation
Contributor
|
@classner thanks for your work! In thinking about easing support for this, I'm tempted to turn rules_uv into a build action w/ a write_source_files target that's runnable to copy built files into the source tree. The gain of that would be getting rid of the bash (and new batch) scripts as we can have Bazel run the toolchain directly. It's been on my backburner to restructure things in this way, hoping to get to it in the next couple of weeks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds changes and functionality to make rules_uv work seamlessly on Windows. It does not make any additional assumptions about the environment (i.e., runs in regular windows batch or powershell, as well as msys2) - one limitation that I have not found a way around is the requirement for the
create_venvtargets to be named in a way that they are recognized as executable scripts by Windows (.cmd or .bat).Let me know what you think!