Skip to content

Add support for multiple requirements.in files#159

Open
froody wants to merge 1 commit intobazel-contrib:mainfrom
froody:multiple_ins
Open

Add support for multiple requirements.in files#159
froody wants to merge 1 commit intobazel-contrib:mainfrom
froody:multiple_ins

Conversation

@froody
Copy link

@froody froody commented Oct 28, 2024

No description provided.

@froody froody requested a review from a team as a code owner October 28, 2024 04:26
@mark-thm
Copy link
Contributor

Thanks — I’d prefer this functionality live outside of this ruleset, though.

@hofbi
Copy link
Contributor

hofbi commented Jan 21, 2025

https://github.com/theoremlp/rules_uv/tree/main/examples/multiple-inputs is a good example how this can be solved with the existing ruleset.

@baxelrod-bdai
Copy link

I'm in favor of this feature. This fixes issue #86.

Minor nit: I'd probably make it so the requirements_in argument can take a single file or list of files rather than make the new argument requirements_ins.

@baxelrod-bdai
Copy link

Actually, this hack is a bit ugly. uv does support multiple .in files. We should just pipe the files all the way to uv instead of concatenating the files ourselves.

@shayanhoshyari
Copy link
Contributor

Thanks — I’d prefer this functionality live outside of this ruleset, though.

+1. Just merge with genrule or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants