Conversation
Member
Author
|
should see on CI that it's still required for bazel before 8.x |
keith
force-pushed
the
ks/delete-osx_cc_wrapper.sh
branch
4 times, most recently
from
3bd73fb to
04c9a0d
Compare
Member
Author
|
looks like this works with 7.x even though |
keith
force-pushed
the
ks/delete-osx_cc_wrapper.sh
branch
from
04c9a0d to
76b5579
Compare
keith
requested review from
BalestraPatrick,
aaronsky,
brentleyjones,
luispadron,
mattrobmattrob and
thii
as code owners
aaronsky
approved these changes
Mar 31, 2025
keith
force-pushed
the
ks/delete-osx_cc_wrapper.sh
branch
from
76b5579 to
032b73c
Compare
Collaborator
|
Looks like bazelbuild/bazel@4956dff is what fixed it. Not sure we should move our minimum up to 7.4.0 just yet? |
Member
Author
|
yea good point we can wait a bit |
This was only used to fix the install_name of shared libraries, which is now obsolete since they are set correctly by the crosstool with `-install_name`.
keith
force-pushed
the
ks/delete-osx_cc_wrapper.sh
branch
from
032b73c to
d476874
Compare
Member
Author
|
probably fine to make 7.4.0 our min now? |
adincebic
approved these changes
Apr 11, 2026
Contributor
IMO yes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was only used to fix the install_name of shared libraries, which is
now obsolete since they are set correctly by the crosstool with
-install_name. This was fixed in 7.4.0+ bazelbuild/bazel@4956dff