Skip to content

xml_tools@0.1.1#7380

Closed
scottpledger wants to merge 1 commit intobazelbuild:mainfrom
scottpledger:xml_tools-v0.1.1
Closed

xml_tools@0.1.1#7380
scottpledger wants to merge 1 commit intobazelbuild:mainfrom
scottpledger:xml_tools-v0.1.1

Conversation

@scottpledger
Copy link
Copy Markdown
Contributor

@bazel-io
Copy link
Copy Markdown
Member

bazel-io commented Feb 1, 2026

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (xml_tools) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the new Bazel module xml_tools at version 0.1.1 to the Bazel Central Registry. The changes appear to be in good order and follow the BCR contribution guidelines. All required files are present, and the presubmit configuration correctly uses a test module.

As per the repository style guide, since this is a new module submission, the new maintainers and repository fields in modules/xml_tools/metadata.json require a manual review. I am therefore requesting a review from @bazelbuild/bcr-maintainers.

@scottpledger scottpledger marked this pull request as ready for review February 1, 2026 04:42
@fmeum fmeum added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Feb 1, 2026
@fmeum
Copy link
Copy Markdown
Contributor

fmeum commented Feb 1, 2026

At first I didn't realize that this is an XML parser written in Starlark - what a feat! Since the BCR contains modules from many language ecosystems (Bazel rules, C++ projects, ...), xml_tools is probably not the most descriptive name. What do you think of alternatives like xml.bzl(with a top-level xml.bzl file exporting the xml symbol, starlark-xml`, etc.?

@scottpledger
Copy link
Copy Markdown
Contributor Author

At first I didn't realize that this is an XML parser written in Starlark - what a feat!

Thanks! I'm actually planning to use this to allow the rules_dotnet codebase to parse csproj/fsproj files and auto-generate appropriate targets for them. (see: bazel-contrib/rules_dotnet#528)

Since the BCR contains modules from many language ecosystems (Bazel rules, C++ projects, ...), xml_tools is probably not the most descriptive name. What do you think of alternatives like xml.bzl(with a top-level xml.bzl file exporting the xml symbol, starlark-xml, etc.?

Aah, good idea. I'll rename it to xml.bzl. I hadn't seen that pattern until I saw bazelrc-presets.bzl, so it's not my go-to yet lol

@scottpledger
Copy link
Copy Markdown
Contributor Author

Alright, I've created #7385 which renames this to xml.bzl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants