Fix String misencoding in event and terminal printing - #30648
Open
fmeum wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
team-Core
The new warning supressions masked real encoding issues that could be reached via `Event` messages. Fix all of them by enforcing the internal string encoding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The new warning supressions masked real encoding issues that could be reached via
Eventmessages.Fix all of them by enforcing the internal string encoding. Update the tests to verify the correct handling of Bazel's internal encoding rather than UTF-8, which isn't used in prod.
Motivation
d4cd8d9
Build API Changes
No
Checklist
Release Notes
RELNOTES: None