docs: Starlark ints are not limited to 32 bits - #30689
Open
karpovantonme wants to merge 1 commit into
Open
Conversation
The page says the int type is limited to 32-bit signed integers and that overflow throws. StarlarkInt has documented the opposite since it moved to arbitrary precision, and the generated page at /rules/lib/int says integers may be of any magnitude and arithmetic is exact. Part of bazelbuild#27257. The float and set part of that issue is already fixed.
github-actions
Bot
added
team-Documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #27257
/rules/languagesays:StarlarkIntsays the opposite, and has for a while:That docstring is what generates
/rules/lib/int, so the two pages on the same site contradict each other. This replaces the stale bullet and links to the generated page so they stay togetherSo one line, no other changes
The float and set half of #27257 is already gone from this page, so I left the issue open rather than closing it with this