[8.8.0] Compare paths as fragments in AbstractActionInputPrefetcher - #30690
Open
fmeum wants to merge 1 commit into
Open
[8.8.0] Compare paths as fragments in AbstractActionInputPrefetcher#30690fmeum wants to merge 1 commit into
AbstractActionInputPrefetcher#30690fmeum wants to merge 1 commit into
Conversation
bazelbuild#27627) This is required because `execRoot` might be located on an action file system overlaying the host file system where downloads are written (see the changes in bazelbuild@b8589c3 for context). PiperOrigin-RevId: 830480221 Change-Id: I217b81a81da80f2050c4ec9082ef5f18cb9a0bc9 (cherry picked from commit 1e9d843)
fmeum
marked this pull request as ready for review
August 12, 2026 14:32
2 tasks
github-actions
Bot
added
team-Remote-Exec
iancha1992
enabled auto-merge
August 12, 2026 16:23
Member
|
@fmeum Is the failure related? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required because
execRootmight be located on an action file system overlaying the host file system where downloads are written (see the changes in b8589c3 for context).Without this fix, a directory that is temporarily made writable during the materialization of a tree artifact isn't recognized as living under the exec root, so it is silently left with its output permissions and files can't be moved into place. This has been observed as a tree artifact whose top-level directory was writable while a subdirectory was left read-only, surfacing as a spurious missing CAS blob error since all materialization errors are converted into that.
PiperOrigin-RevId: 830480221
Change-Id: I217b81a81da80f2050c4ec9082ef5f18cb9a0bc9
(cherry picked from commit 1e9d843)
8.8.0 adaptation: on this branch
setWritableadditionally short-circuits on external repository paths under the output base and obtains the exec root lazily viaexecRoot(), so the fragment comparison is applied to the existingexecRoot()check rather than replacing the condition wholesale.This supersedes #30680, which applies the original patch verbatim and thereby drops the external repository check as well as referencing
execRootas a field, which doesn't exist on this branch.