Commpage: Process-Isolated Benchmarking via Shared Memory#78
Draft
Commpage: Process-Isolated Benchmarking via Shared Memory#78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Today tango loads both the baseline (B) and candidate (C) benchmarks into the same process using
dlopen/LoadLibrary. This is clever but has drawbacks:linux.rs) and Windows IAT patching (windows.rs) exist solely to make executables loadable as shared libraries. These are fragile and there is no guarantee they will continue to work in the future. Especially on Linux where this approach was explicitly banned by dyld.Running each benchmark in its own process and reading measurements through shared memory (the "commpage") solves both problems.