Skip to content

Fixes in action 'List online store pages' #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RiabushenkoA merged 1 commit into from
Aug 14, 2025
Merged

Fixes in action 'List online store pages' #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Apps.Shopify/Actions/OnlineStorePageActions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public async Task<ListPagesResponse> ListPages()
{
var variables = new Dictionary<string, object>()
{
["resourceType"] = TranslatableResource.ONLINE_STORE_PAGE
["resourceType"] = TranslatableResource.PAGE
};
var response = await Client
.Paginate<TranslatableResourceEntity, TranslatableResourcePaginationResponse>(
Expand Down
2 changes: 1 addition & 1 deletion Apps.Shopify/Apps.Shopify.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<Nullable>enable</Nullable>
<Product>Shopify</Product>
<Description>E-commerce platform that enables individuals and businesses to create and manage online stores.</Description>
<Version>1.5.6</Version>
<Version>1.5.7</Version>
<AssemblyName>Apps.Shopify</AssemblyName>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion Apps.Shopify/DataSourceHandlers/OnlineStorePageHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace Apps.Shopify.DataSourceHandlers;

public class OnlineStorePageHandler : TranslatableResourceHandler
{
protected override TranslatableResource ResourceType => TranslatableResource.ONLINE_STORE_PAGE;
protected override TranslatableResource ResourceType => TranslatableResource.PAGE;

public OnlineStorePageHandler(InvocationContext invocationContext) : base(invocationContext)
{
Expand Down
3 changes: 2 additions & 1 deletion Apps.Shopify/TranslatableResource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ public enum TranslatableResource
ONLINE_STORE_ARTICLE,
ONLINE_STORE_BLOG,
ONLINE_STORE_MENU,
ONLINE_STORE_PAGE,
//ONLINE_STORE_PAGE, //does not exist in shopify enum
PAGE,
ONLINE_STORE_THEME,
ONLINE_STORE_THEME_APP_EMBED,
ONLINE_STORE_THEME_JSON_TEMPLATE,
Expand Down
14 changes: 14 additions & 0 deletions Tests.Shopify/StoreTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,19 @@ public async Task GetStoreContent_ReturnsValues()
var result = await action.GetStoreContent(input1,input2,input3);
Assert.IsNotNull(result);
}

[TestMethod]
public async Task ListPages_ReturnsValues()
{
var action = new OnlineStorePageActions(InvocationContext, FileManager);
var input1 = new StoreContentRequest { IncludeShop = true };
var input2 = new LocaleRequest { Locale = "fr" };
var input3 = new GetContentRequest { };
var result = await action.ListPages();

var json = Newtonsoft.Json.JsonConvert.SerializeObject(result);
Console.WriteLine(json);
Assert.IsNotNull(result);
}
}
}