Fix find_button to find the exact match for the button#47
Open
danni wants to merge 1 commit intobbangert:masterfrom
Open
Fix find_button to find the exact match for the button#47danni wants to merge 1 commit intobbangert:masterfrom
danni wants to merge 1 commit intobbangert:masterfrom
Conversation
Including only normalising the space. This also means we only make one XPath request.
Contributor
Author
|
Was generally thinking of going through and cleaning up the XPath for all of the steps to reduce the number of round trips to Selenium required to use LWD. |
Collaborator
|
I'm not convinced that generating complicated xpath like this is actually a win. It definitely improves performance, but I can barely read it. |
Contributor
Author
|
What would make it more readable? |
Collaborator
|
Perhaps starting with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Including only normalising the space.
This also means we only make one XPath request.